Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Launch method to convert input strings #497

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Update Launch method to convert input strings #497

merged 2 commits into from
Jun 12, 2024

Conversation

masesdevelopers
Copy link
Contributor

Description

Update Launch method to convert input strings

Related Issue

fix #482

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added bug Something isn't working KNetCLI KNetCLI related issue KNetPS KNetPS related issue KNetConnectSDK KNetConnectSDK related issue labels Jun 12, 2024
@masesdevelopers masesdevelopers self-assigned this Jun 12, 2024
masesdevelopers
masesdevelopers commented Jun 12, 2024
View reviewed changes
Copy link
Contributor Author

@masesdevelopers masesdevelopers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry peek this PR to version 2.6.*

src/net/KNet/KNetCore.cs Show resolved Hide resolved
@masesdevelopers masesdevelopers mentioned this pull request Jun 12, 2024
Closed
@masesdevelopers masesdevelopers merged commit 14871d8 into masesgroup:master Jun 12, 2024
7 checks passed
@masesdevelopers masesdevelopers deleted the 482-knetcli-does-not-recognize-commands-2 branch June 12, 2024 20:29
masesdevelopers added a commit that referenced this pull request Jun 12, 2024
@masesdevelopers
Update Launch method to convert input strings (#497) (#498)
81aee4a 
* Update Launch method to convert input strings

* Update command execution
@masesdevelopers masesdevelopers mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@masesdevelopers masesdevelopers

Labels
bug Something isn't working KNetCLI KNetCLI related issue KNetConnectSDK KNetConnectSDK related issue KNetPS KNetPS related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KNetCLI, KNetPS and KNetConnect does not recognize commands
1 participant
@masesdevelopers